Stabilize pg_dump output order for similarly-named triggers and policies.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 5102f39440f758ea53c2e1cdea7d8411df1805d2
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-11-04T21:25:05Z
Releases: 13.0
Stabilize pg_dump output order for similarly-named triggers and policies.

The code only compared two triggers' names and namespaces (the latter
being the owning table's schema).  This could result in falling back
to an OID-based sort of similarly-named triggers on different tables.
We prefer to avoid that, so add a comparison of the table names too.
(The sort order is thus table namespace, trigger name, table name,
which is a bit odd, but it doesn't seem worth contorting the code
to work around that.)

Likewise for policy objects, in 9.5 and up.

Complaint and fix by Benjie Gillam.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CAMThMzEEt2mvBbPgCaZ1Ap1N-moGn=Edxmadddjq89WG4NpPtQ@mail.gmail.com

Files

PathChange+/−
src/bin/pg_dump/pg_dump_sort.c modified +24 −0

Discussion