Improve and fix some error handling for REINDEX INDEX/TABLE CONCURRENTLY
Michael Paquier <michael@paquier.xyz>
Improve and fix some error handling for REINDEX INDEX/TABLE CONCURRENTLY This improves the user experience when it comes to restrict several flavors of REINDEX CONCURRENTLY. First, for INDEX, remove a restriction on shared relations as we already check after catalog relations. Then, for TABLE, add a proper error message when attempting to run the command on system catalogs. The code path of CREATE INDEX CONCURRENTLY already complains about that, but if a REINDEX is issued then then the error generated is confusing. While on it, add more tests to check restrictions on catalog indexes and on toast table/index for catalogs. Some error messages are improved, with wording suggestion coming from Tom Lane. Reported-by: Tom Lane Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/23694.1556806002@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/indexcmds.c | modified | +11 −11 |
| src/test/regress/expected/create_index.out | modified | +11 −6 |
| src/test/regress/sql/create_index.sql | modified | +5 −2 |
Discussion
- Inconsistent error message wording for REINDEX CONCURRENTLY 23 messages · 2019-05-02 → 2019-06-20