Fix unobvious interaction between -X switch and subdirectory creation.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 506ef1d07f8b51e9799f6856b03a4317297a39cb
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-01-07T23:20:57Z
Releases: 9.5.1
Fix unobvious interaction between -X switch and subdirectory creation.

Turns out the only reason initdb -X worked is that pg_mkdir_p won't
whine if you point it at something that's a symlink to a directory.
Otherwise, the attempt to create pg_xlog/ just like all the other
subdirectories would have failed.  Let's be a little more explicit
about what's happening.  Oversight in my patch for bug #13853
(mea culpa for not testing -X ...)

Files

PathChange+/−
src/bin/initdb/initdb.c modified +24 −13