Fix pg_dump assertion failure when dumping pg_catalog.

Jeff Davis <jdavis@postgresql.org>

Commit: 501704e826fc75d7d1c8976a8d177f8ce3ea0b4c
Author: Jeff Davis <jdavis@postgresql.org>
Date: 2023-08-22T19:49:40Z
Releases: 16.0
Fix pg_dump assertion failure when dumping pg_catalog.

Commit 396d348b04 did not account for the default collation.

Also, use pg_log_warning() instead of Assert().

Discussion: https://postgr.es/m/ce071503fee88334aa70f360e6e4ea14d48305ee.camel%40j-davis.com
Reviewed-by: Michael Paquier
Backpatch-through: 15

Files

PathChange+/−
src/bin/pg_dump/pg_dump.c modified +53 −16
src/bin/pg_dump/t/002_pg_dump.pl modified +8 −0

Discussion