walmethods.c/h: Make Walfile a struct, rather than a void *
Robert Haas <rhaas@postgresql.org>
walmethods.c/h: Make Walfile a struct, rather than a void * This makes the curent file position and pathname visible in a generic way, so we no longer need current_walfile_name global variable or the get_current_pos() method. Since that purported to be able to fail but never actually did, this also lets us get rid of some unnecessary error-handling code. One risk of this change is that the get_current_pos() method previously cleared the error indicator, and that will no longer happen with the new approach. I looked for a way that this could cause problems and did not find one. The previous code was confused about whether "Walfile" was the implementation-dependent structure representing a WAL file or whether it was a pointer to that stucture. Some of the code used it one way, and some in the other. The compiler tolerated that because void * is interchangeable with void **, but now that Walfile is a struct, it's necessary to be consistent. Hence, some references to "Walfile" have been converted to "Walfile *". Discussion: http://postgr.es/m/CA+TgmoZS0Kw98fOoAcGz8B9iDhdqB4Be4e=vDZaJZ5A-xMYBqA@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/pg_basebackup/receivelog.c | modified | +19 −29 |
| src/bin/pg_basebackup/walmethods.c | modified | +33 −56 |
| src/bin/pg_basebackup/walmethods.h | modified | +18 −9 |
Discussion
- walmethods.c/h are doing some strange things 5 messages · 2022-09-02 → 2022-09-19