Horton

Remove useless casting to same type

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 4f941d432b42eccd99ba0d22e3a59c073ac2406a
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2025-12-02T09:09:32Z
Releases: 19 (unreleased) 
Remove useless casting to same type

This removes some casts where the input already has the same type as
the type specified by the cast.  Their presence could cause risks of
hiding actual type mismatches in the future or silently discarding
qualifiers.  It also improves readability.  Same kind of idea as
7f798aca1d5 and ef8fe693606.  (This does not change all such
instances, but only those hand-picked by the author.)

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://www.postgresql.org/message-id/flat/aSQy2JawavlVlEB0%40ip-10-97-1-34.eu-west-3.compute.internal

Files

PathChange+/−
contrib/btree_gist/btree_utils_num.c modified +2 −2
contrib/cube/cube.c modified +3 −3
contrib/fuzzystrmatch/dmetaphone.c modified +1 −1
contrib/pgcrypto/mbuf.c modified +1 −1
src/backend/access/common/indextuple.c modified +1 −1
src/backend/access/gin/gindatapage.c modified +4 −4
src/backend/access/gin/gininsert.c modified +1 −1
src/backend/access/hash/hash_xlog.c modified +2 −2
src/backend/access/transam/twophase.c modified +1 −1
src/backend/catalog/aclchk.c modified +2 −2
src/backend/commands/tablecmds.c modified +1 −1
src/backend/executor/execExpr.c modified +1 −1
src/backend/executor/execExprInterp.c modified +1 −1
src/backend/executor/execPartition.c modified +1 −1
src/backend/executor/nodeTableFuncscan.c modified +1 −1
src/backend/optimizer/geqo/geqo_pool.c modified +2 −2
src/backend/optimizer/plan/planner.c modified +2 −2
src/backend/optimizer/util/pathnode.c modified +1 −1
src/backend/parser/analyze.c modified +1 −1
src/backend/parser/parse_expr.c modified +2 −2
src/backend/port/sysv_shmem.c modified +1 −1
src/backend/replication/walsender.c modified +1 −1
src/backend/rewrite/rewriteHandler.c modified +1 −1
src/backend/statistics/dependencies.c modified +2 −2
src/backend/statistics/extended_stats.c modified +2 −2
src/backend/statistics/mcv.c modified +1 −1
src/backend/storage/aio/aio.c modified +3 −3
src/backend/storage/aio/method_io_uring.c modified +1 −1
src/backend/storage/ipc/waiteventset.c modified +1 −1
src/backend/storage/lmgr/predicate.c modified +1 −1
src/backend/storage/lmgr/proc.c modified +4 −4
src/backend/utils/adt/arrayfuncs.c modified +2 −2
src/backend/utils/adt/jsonfuncs.c modified +2 −4
src/backend/utils/adt/ruleutils.c modified +1 −1
src/bin/pg_dump/pg_dump.c modified +4 −4
src/common/sha1.c modified +2 −2
src/interfaces/ecpg/ecpglib/descriptor.c modified +1 −1
src/interfaces/ecpg/ecpglib/execute.c modified +8 −10
src/interfaces/ecpg/ecpglib/prepare.c modified +3 −3
src/port/win32ntdll.c modified +1 −1
src/test/modules/test_radixtree/test_radixtree.c modified +1 −1

Discussion