Horton

Improve a bit the tests of pg_walinspect

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 4f1882b960596c35d62c78fb44e14913eff49a85
Author: Michael Paquier <michael@paquier.xyz>
Date: 2023-03-23T02:50:35Z
Releases: 16.0 
Improve a bit the tests of pg_walinspect

This commit improves the tests of pg_walinspect on a few things:
- Remove aggregates for queries that should fail.  If the code is
reworked in such a way that the behavior of these queries is changed,
we would get more input from them, written this way.
- Expect at least one record reported in the valid queries doing scans
across ranges, rather than zero records.
- Adjust a few comments, for consistency.

Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACVaoXW3nJD9zq8E66BEf-phgJfFcKRVJq9GXkuX0b3ULQ@mail.gmail.com

Files

PathChange+/−
contrib/pg_walinspect/expected/oldextversions.out modified +7 −6
contrib/pg_walinspect/expected/pg_walinspect.out modified +16 −16
contrib/pg_walinspect/sql/oldextversions.sql modified +7 −6
contrib/pg_walinspect/sql/pg_walinspect.sql modified +17 −17

Discussion