Fix failure of --jobs with vacuumdb on Windows

Michael Paquier <michael@paquier.xyz>

Commit: 4ed3bda49d5ed4616bfca80dcb3b409be9720aff
Author: Michael Paquier <michael@paquier.xyz>
Date: 2019-08-27T00:12:14Z
Releases: 9.5.20
Fix failure of --jobs with vacuumdb on Windows

FD_SETSIZE needs to be declared before winsock2.h, or it is possible to
run into buffer overflow issues when using --jobs.  This is similar to
pgbench's solution done in a23c641.

This has been introduced by 71d84ef, and older versions have been using
the default value of FD_SETSIZE, defined at 64.  While on it, add a
missing newline to the previously-added error message.

Per buildfarm member jacana, but this impacts all Windows animals
running the TAP tests.  I have reproduced the failure locally to check
the patch.

Author: Michael Paquier
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/20190826054000.GE7005@paquier.xyz
Backpatch-through: 9.5

Files

PathChange+/−
src/bin/scripts/vacuumdb.c modified +5 −1

Discussion

Cited messages not in the archive: 20190826054000.GE7005@paquier.xyz