Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

Noah Misch <noah@leadboat.com>

Commit: 4ec14e5aa1f79d01a2558b694ccbe7756c4d186e
Author: Noah Misch <noah@leadboat.com>
Date: 2019-05-12T17:33:08Z
Releases: 11.4
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

The function had been interpreting SQL_ASCII messages as UTF8, throwing
an error when they were invalid UTF8.  The new behavior is consistent
with pg_do_encoding_conversion().  This affects LOG_DESTINATION_STDERR
and LOG_DESTINATION_EVENTLOG, which will send untranslated bytes to
write() and ReportEventA().  On buildfarm member bowerbird, enabling
log_connections caused an error whenever the role name was not valid
UTF8.  Back-patch to 9.4 (all supported versions).

Discussion: https://postgr.es/m/20190512015615.GD1124997@rfd.leadboat.com

Files

Discussion