Add missing and dangling downlink checks to amcheck

Teodor Sigaev <teodor@sigaev.ru>

Commit: 4eaf7eaccb291f5d32d9f05284bfca9c5744de9a
Author: Teodor Sigaev <teodor@sigaev.ru>
Date: 2018-04-25T15:02:55Z
Releases: 11.0
Add missing and dangling downlink checks to amcheck

When bt_index_parent_check() is called with the heapallindexed option,
allocate a second Bloom filter to fingerprint block numbers that appear
in the downlinks of internal pages.  Use Bloom filter probes when
walking the B-Tree to detect missing downlinks.  This can detect subtle
problems with page deletion/VACUUM, such as corruption caused by the bug
just fixed in commit 6db4b499.

The downlink Bloom filter is bound in size by work_mem.  Its optimal
size is typically far smaller than that of the regular heapallindexed
Bloom filter, especially when the index has high fan-out.

Author: Peter Geoghegan
Reviewer: Teodor Sigaev
Discussion: https://postgr.es/m/CAH2-WznUzY4fWTjm1tBB3JpVz8cCfz7k_qVp5BhuPyhivmWJFg@mail.gmail.com

Files

PathChange+/−
contrib/amcheck/verify_nbtree.c modified +381 −16
doc/src/sgml/amcheck.sgml modified +4 −3

Documentation touched

Discussion