Always pass catalog id to the options validator function specified in
Heikki Linnakangas <heikki.linnakangas@iki.fi>
Always pass catalog id to the options validator function specified in CREATE FOREIGN DATA WRAPPER. Arguably it wasn't a bug because the documentation said that it's passed the catalog ID or zero, but surely we should provide it when it's known. And there isn't currently any scenario where it's not known, and I can't imagine having one in the future either, so better remove the "or zero" escape hatch and always pass a valid catalog ID. Backpatch to 8.4. Martin Pihlak
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/ref/create_foreign_data_wrapper.sgml | modified | +4 −5 |
| src/backend/commands/foreigncmds.c | modified | +23 −9 |
| src/backend/foreign/foreign.c | modified | +3 −3 |
| src/test/regress/expected/foreign_data.out | modified | +4 −4 |