Fix cross-checking of ReservedBackends/max_wal_senders/MaxConnections.
Tom Lane <tgl@sss.pgh.pa.us>
Fix cross-checking of ReservedBackends/max_wal_senders/MaxConnections. We were independently checking ReservedBackends < MaxConnections and max_wal_senders < MaxConnections, but because walsenders aren't allowed to use superuser-reserved connections, that's really the wrong thing. Correct behavior is to insist on ReservedBackends + max_wal_senders being less than MaxConnections. Fix the code and associated documentation. This has been wrong for a long time, but since the situation probably hardly ever arises in the field (especially pre-v10, when the default for max_wal_senders was zero), no back-patch. Discussion: https://postgr.es/m/28271.1520195491@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/config.sgml | modified | +14 −9 |
| src/backend/postmaster/postmaster.c | modified | +6 −9 |
| src/backend/utils/init/postinit.c | modified | +1 −1 |
| src/backend/utils/misc/guc.c | modified | +3 −2 |
Documentation touched
Discussion
- Server won't start with fallback setting by initdb. 17 messages · 2018-02-09 → 2018-03-08