Get rid of ExecAssignResultTypeFromOuterPlan() and make all plan node types
Tom Lane <tgl@sss.pgh.pa.us>
Get rid of ExecAssignResultTypeFromOuterPlan() and make all plan node types generate their output tuple descriptors from their target lists (ie, using ExecAssignResultTypeFromTL()). We long ago fixed things so that all node types have minimally valid tlists, so there's no longer any good reason to have two different ways of doing it. This change is needed to fix bug reported by Hayden James: the fix of 2005-11-03 to emit the correct column names after optimizing away a SubqueryScan node didn't work if the new top-level plan node used ExecAssignResultTypeFromOuterPlan to generate its tupdesc, since the next plan node down won't have the correct column labels.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execUtils.c | modified | +1 −17 |
| src/backend/executor/nodeHash.c | modified | +2 −2 |
| src/backend/executor/nodeLimit.c | modified | +2 −2 |
| src/backend/executor/nodeMaterial.c | modified | +2 −2 |
| src/backend/executor/nodeSetOp.c | modified | +2 −2 |
| src/backend/executor/nodeSort.c | modified | +2 −2 |
| src/backend/executor/nodeUnique.c | modified | +2 −2 |
| src/include/executor/executor.h | modified | +1 −2 |