Remove remants of "snapshot too old"
Heikki Linnakangas <heikki.linnakangas@iki.fi>
Remove remants of "snapshot too old" Remove the 'whenTaken' and 'lsn' fields from SnapshotData. After the removal of the "snapshot too old" feature, they were never set to a non-zero value. This largely reverts commit 3e2f3c2e423, which added the OldestActiveSnapshot tracking, and the init_toast_snapshot() function. That was only required for setting the 'whenTaken' and 'lsn' fields. SnapshotToast is now a constant again, like SnapshotSelf and SnapshotAny. I kept a thin get_toast_snapshot() wrapper around SnapshotToast though, to check that you have a registered or active snapshot. That's still a useful sanity check. Reviewed-by: Nathan Bossart, Andres Freund, Tom Lane Discussion: https://www.postgresql.org/message-id/cd4b4f8c-e63a-41c0-95f6-6e6cd9b83f6d@iki.fi
Files
| Path | Change | +/− |
|---|---|---|
| contrib/amcheck/verify_heapam.c | modified | +1 −3 |
| src/backend/access/common/toast_internals.c | modified | +18 −33 |
| src/backend/access/heap/heaptoast.c | modified | +1 −3 |
| src/backend/storage/ipc/procarray.c | modified | +0 −4 |
| src/backend/utils/time/snapmgr.c | modified | +1 −53 |
| src/include/access/genam.h | modified | +2 −0 |
| src/include/access/toast_internals.h | modified | +1 −1 |
| src/include/storage/predicate.h | modified | +1 −0 |
| src/include/utils/snapmgr.h | modified | +3 −10 |
| src/include/utils/snapshot.h | modified | +0 −7 |
Discussion
- Remove remnants of "snapshot too old" 6 messages · 2024-12-03 → 2024-12-04