Fix variable initialization when using buffering build with GiST

Michael Paquier <michael@paquier.xyz>

Commit: 4d713595914beb705539ca5cd09c8b3a95f65c70
Author: Michael Paquier <michael@paquier.xyz>
Date: 2019-07-10T06:15:03Z
Releases: 12.0
Fix variable initialization when using buffering build with GiST

This can cause valgrind to complain, as the flag marking a buffer as a
temporary copy was not getting initialized.

While on it, fill in with zeros newly-created buffer pages.  This does
not matter when loading a block from a temporary file, but it makes the
push of an index tuple into a new buffer page safer.

This has been introduced by 1d27dcf, so backpatch all the way down to
9.4.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/15899-0d24fb273b3dd90c@postgresql.org
Backpatch-through: 9.4

Files

PathChange+/−
src/backend/access/gist/gistbuildbuffers.c modified +3 −2

Discussion