Horton

Improve range checks of options for pg_test_fsync and pg_test_timing

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 4d29e6dbd0bb6d8c3a48d0f3c7d65dc1def1b07e
Author: Michael Paquier <michael@paquier.xyz>
Date: 2020-09-28T01:13:59Z
Releases: 14.0 
Improve range checks of options for pg_test_fsync and pg_test_timing

Both tools never had safeguard checks for the options provided, and it
was possible to make pg_test_fsync run an infinite amount of time or
pass down buggy values to pg_test_timing.

These behaviors have existed for a long time, with no actual complaints,
so no backpatch is done.  Basic TAP tests are introduced for both tools.

Author: Michael Paquier
Reviewed-by: Peter Eisentraut
Discussion: https://postgr.es/m/20200806062759.GE16470@paquier.xyz

Files

PathChange+/−
src/bin/pg_test_fsync/.gitignore modified +2 −0
src/bin/pg_test_fsync/Makefile modified +6 −0
src/bin/pg_test_fsync/pg_test_fsync.c modified +24 −4
src/bin/pg_test_fsync/t/001_basic.pl added +25 −0
src/bin/pg_test_timing/.gitignore modified +2 −0
src/bin/pg_test_timing/Makefile modified +6 −0
src/bin/pg_test_timing/pg_test_timing.c modified +31 −20
src/bin/pg_test_timing/t/001_basic.pl added +25 −0

Discussion