Use bitwise rotate functions in more places
John Naylor <john.naylor@postgresql.org>
Use bitwise rotate functions in more places There were a number of places in the code that used bespoke bit-twiddling expressions to do bitwise rotation. While we've had pg_rotate_right32() for a while now, we hadn't gotten around to standardizing on that. Do so now. Since many potential call sites look more natural with the "left" equivalent, add that function too. Reviewed by Tom Lane and Yugo Nagata Discussion: https://www.postgresql.org/message-id/CAFBsxsH7c1LC0CGZ0ADCBXLHU5-%3DKNXx-r7tHYPAW51b2HK4Qw%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execGrouping.c | modified | +2 −2 |
| src/backend/executor/nodeHash.c | modified | +2 −2 |
| src/backend/executor/nodeMemoize.c | modified | +4 −4 |
| src/backend/utils/adt/jsonb_util.c | modified | +2 −1 |
| src/backend/utils/adt/multirangetypes.c | modified | +2 −1 |
| src/backend/utils/adt/rangetypes.c | modified | +2 −1 |
| src/backend/utils/cache/catcache.c | modified | +4 −10 |
| src/common/hashfn.c | modified | +2 −2 |
| src/include/port/pg_bitutils.h | modified | +8 −2 |