Horton

Revert "For inplace update, send nontransactional invalidations."

Noah Misch <noah@leadboat.com>

View on postgr.es
Commit: 4b0f7d6c162e9a52e5c2bf1098d4ffd0b107425c
Author: Noah Misch <noah@leadboat.com>
Date: 2024-11-02T16:05:08Z
Releases: 12.21 
Revert "For inplace update, send nontransactional invalidations."

This reverts commit 95c5acb3fc261067ab65ddc0b2dca8e162f09442 (v17) and
counterparts in each other non-master branch.  If released, that commit
would have caused a worst-in-years minor release regression, via
undetected LWLock self-deadlock.  This commit and its self-deadlock fix
warrant more bake time in the master branch.

Reported by Alexander Lakhin.

Discussion: https://postgr.es/m/10ec0bc3-5933-1189-6bb8-5dec4114558e@gmail.com

Files

PathChange+/−
src/backend/access/heap/heapam.c modified +7 −36
src/backend/access/transam/xact.c modified +8 −18
src/backend/catalog/index.c modified +2 −9
src/backend/replication/logical/decode.c modified +15 −11
src/backend/utils/cache/catcache.c modified +3 −4
src/backend/utils/cache/inval.c modified +71 −188
src/backend/utils/cache/syscache.c modified +2 −1
src/include/utils/catcache.h modified +1 −2
src/include/utils/inval.h modified +0 −6
src/test/isolation/expected/inplace-inval.out modified +1 −9
src/test/isolation/specs/inplace-inval.spec modified +7 −5

Discussion