Remove configure's check for rl_completion_append_character.
Tom Lane <tgl@sss.pgh.pa.us>
Remove configure's check for rl_completion_append_character. The comment for PGAC_READLINE_VARIABLES says "Readline versions < 2.1 don't have rl_completion_append_character". It seems certain that such versions are extinct in the wild, though; for sure there are none in the buildfarm. Libedit has had this variable for at least twenty years too. Also, tab-complete.c's behavior without it is quite unfriendly, since we'll emit a space even when completion fails; but we've had no complaints about that. Therefore, let's assume this variable is always there, and drop the configure check to save a few build cycles. Discussion: https://postgr.es/m/147685.1643858911@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| config/programs.m4 | modified | +2 −20 |
| configure | modified | +1 −40 |
| src/bin/psql/tab-complete.c | modified | +1 −9 |
| src/include/pg_config.h.in | modified | +0 −4 |
| src/tools/msvc/Solution.pm | modified | +0 −1 |
Discussion
- psql tab completion versus Debian's libedit 5 messages · 2022-02-01 → 2022-02-03