Fix fuzzy thinking about amcanmulticol versus amcaninclude.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 4ac8ee9d4878dadccc2331d8d1b1769c97f4ebe9
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-11-15T21:10:48Z
Releases: 12.6
Fix fuzzy thinking about amcanmulticol versus amcaninclude.

These flags should be independent: in particular an index AM should
be able to say that it supports include columns without necessarily
supporting multiple key columns.  The included-columns patch got
this wrong, possibly aided by the fact that it didn't bother to
update the documentation.

While here, clarify some text about amcanreturn, which was a little
vague about what should happen when amcanreturn reports that only
some of the index columns are returnable.

Noted while reviewing the SP-GiST included-columns patch, which
quite incorrectly (and unsafely) changed SP-GiST to claim
amcanmulticol = true as a workaround for this bug.

Backpatch to v11 where included columns were introduced.

Files

PathChange+/−
doc/src/sgml/indexam.sgml modified +27 −8
src/backend/commands/indexcmds.c modified +2 −2

Documentation touched