Code review for holdable-cursors patch. Fix error recovery, memory
Tom Lane <tgl@sss.pgh.pa.us>
Code review for holdable-cursors patch. Fix error recovery, memory context sloppiness, some other things. Includes Neil's mopup patch of 22-Apr.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/ref/declare.sgml | modified | +17 −13 |
| src/backend/catalog/sql_features.txt | modified | +6 −6 |
| src/backend/commands/portalcmds.c | modified | +149 −139 |
| src/backend/executor/spi.c | modified | +2 −2 |
| src/backend/executor/tstoreReceiver.c | modified | +13 −3 |
| src/backend/parser/analyze.c | modified | +2 −2 |
| src/backend/parser/gram.y | modified | +2 −3 |
| src/backend/storage/file/buffile.c | modified | +9 −6 |
| src/backend/storage/file/fd.c | modified | +72 −39 |
| src/backend/utils/mmgr/portalmem.c | modified | +69 −68 |
| src/backend/utils/sort/tuplestore.c | modified | +14 −11 |
| src/include/commands/portalcmds.h | modified | +2 −2 |
| src/include/storage/buffile.h | modified | +2 −2 |
| src/include/storage/fd.h | modified | +2 −2 |
| src/include/utils/portal.h | modified | +9 −9 |
| src/include/utils/tuplestore.h | modified | +2 −2 |
| src/test/regress/expected/portals.out | modified | +1 −1 |
| src/test/regress/sql/portals.sql | modified | +2 −2 |