Horton

Drop slot's LWLock before returning from SaveSlotToPath()

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 49bf81536e242f079bfbce6e8f95f53f18207dd5
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2020-03-26T12:29:20Z
Releases: 13.0 
Drop slot's LWLock before returning from SaveSlotToPath()

When SaveSlotToPath() is called with elevel=LOG, the early exits didn't
release the slot's io_in_progress_lock.

This could result in a walsender being stuck on the lock forever.  A
possible way to get into this situation is if the offending code paths
are triggered in a low disk space situation.

Author: Pavan Deolasee <pavan.deolasee@2ndquadrant.com>
Reported-by: Craig Ringer <craig@2ndquadrant.com>
Discussion: https://www.postgresql.org/message-id/flat/56a138c5-de61-f553-7e8f-6789296de785%402ndquadrant.com

Files

PathChange+/−
src/backend/replication/slot.c modified +10 −0

Discussion