Horton

pg_dump: include comments on valid not-null constraints, too

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: 47fb87563bf3cca2244840241dde2eb93830559b
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2025-06-26T16:24:12Z
Releases: 18.0 
pg_dump: include comments on valid not-null constraints, too

We were missing collecting comments for not-null constraints that are
dumped inline with the table definition (i.e., valid ones), because they
aren't represented by a separately dumpable object.  Fix by creating
separate TocEntries for the comments.

Co-Authored-By: Jian He <jian.universality@gmail.com>
Co-Authored-By: Álvaro Herrera <alvherre@kurilemu.de>
Reported-By: Fujii Masao <masao.fujii@oss.nttdata.com>
Reviewed-By: Fujii Masao <masao.fujii@oss.nttdata.com>
Discussion: https://postgr.es/m/d50ff977-c728-4e9e-8488-fc2688e08754@oss.nttdata.com

Files

PathChange+/−
doc/src/sgml/ref/pg_dump.sgml modified +1 −1
src/bin/pg_dump/pg_dump.c modified +80 −12
src/bin/pg_dump/pg_dump.h modified +1 −0
src/bin/pg_dump/t/002_pg_dump.pl modified +31 −1
src/test/regress/expected/constraints.out modified +2 −0
src/test/regress/sql/constraints.sql modified +3 −0

Documentation touched

Discussion