Avoid possible regression test instability in timestamp.sql.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 47169c25500a70a7d04076860717f2f4f0ea83a7
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2019-04-15T20:20:01Z
Releases: 12.0
Avoid possible regression test instability in timestamp.sql.

Concurrent autovacuum could result in a change in the order of the
live rows in timestamp_tbl.  While this would not happen with the
default autovacuum parameters, it's fairly easy to hit if
autovacuum_vacuum_threshold is made small enough to allow autovac
to decide to process this table.  That's a stumbling block for trying
to exercise autovacuum aggressively using the core regression tests.

To fix, replace an unqualified DELETE with a TRUNCATE.  There's a
similar DELETE just above (and no order-sensitive queries between),
so this doesn't lose any test coverage and might indeed be argued
to improve it.

Discussion: https://postgr.es/m/17428.1555348950@sss.pgh.pa.us

Files

Discussion