Improve accounting for PredXactList, RWConflictPool and PGPROC

Tomas Vondra <tomas.vondra@postgresql.org>

Commit: 46df9487d973d00c83a7962935063f3a6518939c
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2025-04-02T15:14:28Z
Releases: 18.0
Improve accounting for PredXactList, RWConflictPool and PGPROC

Various places allocated shared memory by first allocating a small chunk
using ShmemInitStruct(), followed by ShmemAlloc() calls to allocate more
memory. Unfortunately, ShmemAlloc() does not update ShmemIndex, so this
affected pg_shmem_allocations - it only shown the initial chunk.

This commit modifies the following allocations, to allocate everything
as a single chunk, and then split it internally.

- PredXactList
- RWConflictPool
- PGPROC structures
- Fast-Path Lock Array

The fast-path lock array is allocated separately, not as a part of the
PGPROC structures allocation.

Author: Rahila Syed <rahilasyed90@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://postgr.es/m/CAH2L28vHzRankszhqz7deXURxKncxfirnuW68zD7+hVAqaS5GQ@mail.gmail.com

Files

PathChange+/−
src/backend/storage/lmgr/predicate.c modified +20 −10
src/backend/storage/lmgr/proc.c modified +71 −22

Discussion