nbtree: Demote incomplete split "can't happen" error.

Peter Geoghegan <pg@bowt.ie>

Commit: 46cf3c72c36fef8c623b4b97d8720321d8ad7507
Author: Peter Geoghegan <pg@bowt.ie>
Date: 2020-11-15T19:53:37Z
Releases: 14.0
nbtree: Demote incomplete split "can't happen" error.

Only a basic logic bug in a _bt_insertonpg() caller could lead to a
violation of this invariant (index corruption won't do it).  A "can't
happen" error seems inappropriate (it is arbitrary at best).

Demote the error to a simple assertion.  This matches similar nearby
sanity checks.

Files

PathChange+/−
src/backend/access/nbtree/nbtinsert.c modified +2 −5