Suppress warning about stack_base_ptr with late-model GCC.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 46b738ffc2bf27c1c0bf0492f8c646c4496819dc
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2022-02-18T03:45:34Z
Releases: 13.7
Suppress warning about stack_base_ptr with late-model GCC.

GCC 12 complains that set_stack_base is storing the address of
a local variable in a long-lived pointer.  This is an entirely
reasonable warning (indeed, it just helped us find a bug);
but that behavior is intentional here.  We can work around it
by using __builtin_frame_address(0) instead of a specific local
variable; that produces an address a dozen or so bytes different,
in my testing, but we don't care about such a small difference.
Maybe someday a compiler lacking that function will start to issue
a similar warning, but we'll worry about that when it happens.

Patch by me, per a suggestion from Andres Freund.  Back-patch to
v12, which is as far back as the patch will go without some pain.
(Recently-established project policy would permit a back-patch as
far as 9.2, but I'm disinclined to expend the work until GCC 12
is much more widespread.)

Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us

Files

PathChange+/−
config/c-compiler.m4 modified +22 −0
configure modified +40 −0
configure.in modified +3 −0
src/backend/postmaster/postmaster.c modified +1 −1
src/backend/tcop/postgres.c modified +11 −1
src/backend/utils/init/miscinit.c modified +5 −6
src/include/pg_config.h.in modified +3 −0
src/tools/msvc/Solution.pm modified +1 −0

Discussion