Revert "Distinguish printf-like functions that support %m from those that don't."
Tom Lane <tgl@sss.pgh.pa.us>
Revert "Distinguish printf-like functions that support %m from those that don't." This reverts commit 3a60c8ff892a8242b907f44702bfd9f1ff877d45. Buildfarm results show that that caused a whole bunch of new warnings on platforms where gcc believes the local printf to be non-POSIX-compliant. This problem outweighs the hypothetical-anyway possibility of getting warnings for misuse of %m. We could use gnu_printf archetype when we've substituted src/port/snprintf.c, but that brings us right back to the problem of not getting warnings for %m. A possible answer is to attack it in the other direction by insisting that %m support be included in printf's feature set, but that will take more investigation. In the meantime, revert the previous change, and update the comment for PGAC_C_PRINTF_ARCHETYPE to more fully explain what's going on. Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| config/c-compiler.m4 | modified | +13 −7 |
| configure | modified | +3 −3 |
| src/include/c.h | modified | +1 −5 |
| src/include/pg_config.h.in | modified | +2 −2 |
| src/include/utils/elog.h | modified | +15 −15 |
Discussion
- Allowing printf("%m") only where it actually works 50 messages · 2018-05-21 → 2018-10-09