Code review for range-types catalog entries.
Tom Lane <tgl@sss.pgh.pa.us>
Code review for range-types catalog entries. Fix assorted infelicities, such as dependency on OIDs that aren't hardwired, as well as outright misdeclaration of daterange_canonical(), which resulted in crashes if you invoked it directly. Add some more regression tests to try to catch similar mistakes in future.
Files
| Path | Change | +/− |
|---|---|---|
| src/include/catalog/catversion.h | modified | +1 −1 |
| src/include/catalog/indexing.h | modified | +1 −1 |
| src/include/catalog/pg_opclass.h | modified | +15 −8 |
| src/include/catalog/pg_operator.h | modified | +20 −19 |
| src/include/catalog/pg_proc.h | modified | +25 −25 |
| src/include/catalog/pg_range.h | modified | +7 −7 |
| src/include/catalog/pg_type.h | modified | +2 −3 |
| src/test/regress/expected/rangetypes.out | modified | +13 −13 |
| src/test/regress/expected/type_sanity.out | modified | +49 −1 |
| src/test/regress/sql/rangetypes.sql | modified | +6 −6 |
| src/test/regress/sql/type_sanity.sql | modified | +40 −1 |