Remove some ancient and unmaintained encoding-conversion test cruft.
Tom Lane <tgl@sss.pgh.pa.us>
Remove some ancient and unmaintained encoding-conversion test cruft. In commit 921191912c48a68d I claimed that we weren't testing encoding conversion functions, but further poking around reveals that we did have an equivalent though hard-wired set of tests in conversion.sql. AFAICS there is no advantage to doing it like that as compared to letting the catalog contents drive the test, so let the opr_sanity addition stand and remove the now-redundant tests in conversion.sql. Also, remove some infrastructure in src/backend/utils/mb/conversion_procs for building conversion.sql's list of tests. That was unmaintained, and had not corresponded to the actual contents of conversion.sql since 2007 or perhaps even further back.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/mb/conversion_procs/Makefile | modified | +0 −20 |
| src/backend/utils/mb/conversion_procs/regress_epilogue | deleted | +0 −5 |
| src/backend/utils/mb/conversion_procs/regress_prolog | deleted | +0 −25 |
| src/test/regress/expected/conversion.out | modified | +4 −914 |
| src/test/regress/sql/conversion.sql | modified | +4 −265 |