Code review for GUC revert-values-if-removed-from-postgresql.conf patch;
Tom Lane <tgl@sss.pgh.pa.us>
Code review for GUC revert-values-if-removed-from-postgresql.conf patch; and in passing, fix some bogosities dating from the custom_variable_classes patch. Fix guc-file.l to correctly check changes in custom_variable_classes that are attempted concurrently with additions/removals of custom variables, and don't allow the new setting to be applied in advance of checking it. Clean up messy and undocumented situation for string variables with NULL boot_val. Fix DefineCustomVariable functions to initialize boot_val correctly. Prevent find_option from inserting bogus placeholders for custom variables that are simply inquired about rather than being set.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/cache/ts_cache.c | modified | +2 −10 |
| src/backend/utils/misc/guc.c | modified | +214 −229 |
| src/backend/utils/misc/guc-file.l | modified | +171 −142 |
| src/backend/utils/misc/README | modified | +9 −1 |
| src/include/utils/guc_tables.h | modified | +11 −10 |