Horton

Revert 019_replslot_limit.pl related debugging aids.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: 3f8148c256e067dc2e8929ed174671ba7dc3339c
Author: Andres Freund <andres@anarazel.de>
Date: 2022-07-05T18:01:10Z
Releases: 16.0 
Revert 019_replslot_limit.pl related debugging aids.

This reverts most of 91c0570a791, f28bf667f60, fe0972ee5e6, afdeff10526. The
only thing left is the retry loop in 019_replslot_limit.pl that avoids
spurious failures by retrying a couple times.

We haven't seen any hard evidence that this is caused by anything but slow
process shutdown. We did not find any cases where walsenders did not vanish
after waiting for longer. Therefore there's no reason for this debugging code
to remain.

Discussion: https://postgr.es/m/20220530190155.47wr3x2prdwyciah@alap3.anarazel.de
Backpatch: 15-

Files

PathChange+/−
src/backend/replication/slot.c modified +0 −43
src/backend/storage/lmgr/lwlock.c modified +0 −7
src/backend/utils/init/postinit.c modified +0 −18
src/bin/pg_basebackup/pg_basebackup.c modified +1 −9
src/include/storage/lwlock.h modified +0 −1
src/test/recovery/t/019_replslot_limit.pl modified +4 −9

Discussion