Fix end-of-loop optimization in pglz_find_match() function.

Heikki Linnakangas <heikki.linnakangas@iki.fi>

Commit: 3f2adace1ec025908b5189f0773b4eaab3d228d5
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2013-07-17T17:37:09Z
Releases: 9.4.0
Fix end-of-loop optimization in pglz_find_match() function.

After the recent pglz optimization patch, the next/prev pointers in the
hash table are never NULL, INVALID_ENTRY_PTR is used to represent invalid
entries instead. The end-of-loop check in pglz_find_match() function didn't
get the memo. The result was the same from a correctness point of view, but
because the NULL-check would never fail, the tiny optimization turned into
a pessimization.

Reported by Stephen Frost, using Coverity scanner.

Files

PathChange+/−
src/backend/utils/adt/pg_lzcompress.c modified +1 −1