Check for fseeko() failure in pg_dump's _tarAddFile().

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 3ed76bd3592f9d476edc0616b527c6fdce71ce85
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2020-08-09T16:39:08Z
Releases: 10.14
Check for fseeko() failure in pg_dump's _tarAddFile().

Coverity pointed out, not unreasonably, that we checked fseeko's
result at every other call site but these.  Failure to seek in the
temp file (note this is NOT pg_dump's output file) seems quite
unlikely, and even if it did happen the file length cross-check
further down would probably detect the problem.  Still, that's a
poor excuse for not checking the result of a system call.

Files

PathChange+/−
src/bin/pg_dump/pg_backup_tar.c modified +6 −2