Fix nbtree page deletion error messages.

Peter Geoghegan <pg@bowt.ie>

Commit: 3d8d5787a358156edaa7782f0c88e231af974a01
Author: Peter Geoghegan <pg@bowt.ie>
Date: 2021-03-02T21:02:24Z
Releases: 14.0
Fix nbtree page deletion error messages.

Adjust some "can't happen" error messages that assumed that the page
deletion target page must be a half-dead page.  This assumption was
wrong in the case of an internal target page.  Simply refer to these
pages as the target page instead.

Internal pages are never marked half-dead.  There is exactly one
half-dead page for each subtree undergoing deletion.  The half-dead page
is also the target subtree's leaf-level page.  This has been the case
since commit efada2b8, which totally overhauled nbtree page deletion.

Files

PathChange+/−
src/backend/access/nbtree/nbtpage.c modified +7 −6