Fix assorted oversights in range selectivity estimation.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 3d660d33aab2f1eb98367a84eb2addf3e0969c05
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-01-30T17:30:59Z
Releases: 9.5.0
Fix assorted oversights in range selectivity estimation.

calc_rangesel() failed outright when comparing range variables to empty
constant ranges with < or >=, as a result of missing cases in a switch.
It also produced a bogus estimate for > comparison to an empty range.

On top of that, the >= and > cases were mislabeled throughout.  For
nonempty constant ranges, they managed to produce the right answers
anyway as a result of counterbalancing typos.

Also, default_range_selectivity() omitted cases for elem <@ range,
range &< range, and range &> range, so that rather dubious defaults
were applied for these operators.

In passing, rearrange the code in rangesel() so that the elem <@ range
case is handled in a less opaque fashion.

Report and patch by Emre Hasegeli, some additional work by me

Files