Be more paranoid about null return values from libpq status functions.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 3d357b48f901503ecc69c529e5bbcd3f84ba5094
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2015-11-25T22:31:53Z
Releases: 9.4.6
Be more paranoid about null return values from libpq status functions.

PQhost() can return NULL in non-error situations, namely when a Unix-socket
connection has been selected by default.  That behavior is a tad debatable
perhaps, but for the moment we should make sure that psql copes with it.
Unfortunately, do_connect() failed to: it could pass a NULL pointer to
strcmp(), resulting in crashes on most platforms.  This was reported as a
security issue by ChenQin of Topsec Security Team, but the consensus of
the security list is that it's just a garden-variety bug with no security
implications.

For paranoia's sake, I made the keep_password test not trust PQuser or
PQport either, even though I believe those will never return NULL given
a valid PGconn.

Back-patch to all supported branches.

Files

PathChange+/−
src/bin/psql/command.c modified +13 −10