Avoid unnecessary catalog updates in ALTER SEQUENCE

Peter Eisentraut <peter_e@gmx.net>

Commit: 3d092fe5409b98272ddd6e623b657308a3c5f004
Author: Peter Eisentraut <peter_e@gmx.net>
Date: 2017-05-02T14:41:48Z
Releases: 10.0
Avoid unnecessary catalog updates in ALTER SEQUENCE

ALTER SEQUENCE can do nontransactional changes to the sequence (RESTART
clause) and transactional updates to the pg_sequence catalog (most other
clauses).  When just calling RESTART, the code would still needlessly do
a catalog update without any changes.  This would entangle that
operation in the concurrency issues of a catalog update (causing either
locking or concurrency errors, depending on how that issue is to be
resolved).

Fix by keeping track during options parsing whether a catalog update is
needed, and skip it if not.

Reported-by: Jason Petersen <jason@citusdata.com>

Files

PathChange+/−
src/backend/commands/sequence.c modified +43 −8