Fix out-of-bounds access in autoprewarm worker
Tomas Vondra <tomas.vondra@postgresql.org>
Author:
Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2026-06-26T17:48:20Z
Releases:
18 (unreleased)
Fix out-of-bounds access in autoprewarm worker The read stream callback apw_read_stream_next_block() advances p->pos through the block_info array. When processing the last block, it increments p->pos to prewarm_stop_idx before returning. The callback itself is safe because it checks bounds before accessing the array. However, the caller assigned blk from block_info[i] at the end of the loop body, before the loop condition was re-evaluated. When i equaled prewarm_stop_idx, this accessed memory beyond the allocated DSM segment, causing a segfault. Restructure the loop to check bounds at the top and assign blk at the beginning of the loop body, where it is always safe. This avoids the need for an explicit bounds check at the end. Backpatch to 18, where the bug was introduced by commit 6acab8bdbcda. Author: Matheus Alcantara <mths.dev@pm.me> Reported-by: Glauber Batista <glauberrbatista@gmail.com> Reviewed-by: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Tomas Vondra <tomas@vondra.me> Backpatch-through: 18 Discussion: https://www.postgresql.org/message-id/CAO%2B_mTQgQyTYwDh%3DU8iTnsDmOGyWsZJjUV31SmEYwmw6_xY6Bw%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| contrib/pg_prewarm/autoprewarm.c | modified | +15 −5 |
Discussion
- Autoprewarm workers terminated due to a segmentation fault 9 messages · 2026-06-09 → 2026-06-29