Invent "join domains" to replace the below_outer_join hack.
Tom Lane <tgl@sss.pgh.pa.us>
Invent "join domains" to replace the below_outer_join hack. EquivalenceClasses are now understood as applying within a "join domain", which is a set of inner-joined relations (possibly underneath an outer join). We no longer need to treat an EC from below an outer join as a second-class citizen. I have hopes of eventually being able to treat outer-join clauses via EquivalenceClasses, by means of only applying deductions within the EC's join domain. There are still problems in the way of that, though, so for now the reconsider_outer_join_clause logic is still here. I haven't been able to get rid of RestrictInfo.is_pushed_down either, but I wonder if that could be recast using JoinDomains. I had to hack one test case in postgres_fdw.sql to make it still test what it was meant to, because postgres_fdw is inconsistent about how it deals with quals containing non-shippable expressions; see https://postgr.es/m/1691374.1671659838@sss.pgh.pa.us. That should be improved, but I don't think it's within the scope of this patch series. Patch by me; thanks to Richard Guo for review. Discussion: https://postgr.es/m/830269.1656693747@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| contrib/postgres_fdw/expected/postgres_fdw.out | modified | +7 −7 |
| contrib/postgres_fdw/sql/postgres_fdw.sql | modified | +1 −1 |
| src/backend/nodes/outfuncs.c | modified | +0 −1 |
| src/backend/optimizer/path/equivclass.c | modified | +80 −53 |
| src/backend/optimizer/path/joinpath.c | modified | +0 −12 |
| src/backend/optimizer/plan/createplan.c | modified | +1 −4 |
| src/backend/optimizer/plan/initsplan.c | modified | +111 −102 |
| src/backend/optimizer/plan/planner.c | modified | +10 −0 |
| src/backend/optimizer/prep/prepjointree.c | modified | +2 −0 |
| src/include/nodes/pathnodes.h | modified | +56 −11 |
| src/include/optimizer/paths.h | modified | +1 −1 |
| src/include/optimizer/planmain.h | modified | +0 −1 |
Discussion
- Making Vars outer-join aware 60 messages · 2022-07-01 → 2023-07-23