Improve tuplestore's error messages for I/O failures.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 3ba1776c568e36423ee66892481b6d1703f4fbd8
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2014-06-12T22:59:14Z
Releases: 9.4.0
Improve tuplestore's error messages for I/O failures.

We should report the errno when we get a failure from functions like
BufFileWrite.  "ERROR: write failed" is unreasonably taciturn for a
case that's well within the realm of possibility; I've seen it a
couple times in the buildfarm recently, in situations that were
probably out-of-disk-space, but it'd be good to see the errno
to confirm it.

I think this code was originally written without assuming that
the buffile.c functions would return useful errno; but most other
callers *are* assuming that, and a quick look at the buffile code
gives no reason to suppose otherwise.

Also, a couple of the old messages were phrased on the assumption
that a short read might indicate a logic bug in tuplestore itself;
but that code's pretty well tested by now, so a filesystem-level
problem seems much more likely.

Files

PathChange+/−
src/backend/utils/sort/logtape.c modified +1 −4
src/backend/utils/sort/tuplestore.c modified +46 −18