Horton

Use new overflow-safe integer comparison functions.

Nathan Bossart <nathan@postgresql.org>

View on postgr.es
Commit: 3b42bdb47169c617cb79123c407a19d16458b49a
Author: Nathan Bossart <nathan@postgresql.org>
Date: 2024-02-16T20:05:36Z
Releases: 17.0 
Use new overflow-safe integer comparison functions.

Commit 6b80394781 introduced integer comparison functions designed
to be as efficient as possible while avoiding overflow.  This
commit makes use of these functions in many of the in-tree qsort()
comparators to help ensure transitivity.  Many of these comparator
functions should also see a small performance boost.

Author: Mats Kindahl
Reviewed-by: Andres Freund, Fabrízio de Royes Mello
Discussion: https://postgr.es/m/CA%2B14426g2Wa9QuUpmakwPxXFWG_1FaY0AsApkvcTBy-YfS6uaw%40mail.gmail.com

Files

PathChange+/−
contrib/hstore/hstore_gist.c modified +3 −1
contrib/intarray/_intbig_gist.c modified +3 −1
contrib/intarray/_int_tool.c modified +3 −6
contrib/pg_stat_statements/pg_stat_statements.c modified +2 −6
contrib/pg_trgm/trgm_op.c modified +2 −6
src/backend/access/nbtree/nbtinsert.c modified +2 −6
src/backend/access/nbtree/nbtpage.c modified +3 −7
src/backend/access/nbtree/nbtsplitloc.c modified +2 −6
src/backend/access/spgist/spgdoinsert.c modified +2 −3
src/backend/access/spgist/spgtextproc.c modified +2 −1
src/backend/backup/basebackup_incremental.c modified +2 −6
src/backend/backup/walsummary.c modified +2 −5
src/backend/catalog/heap.c modified +2 −5
src/backend/nodes/list.c modified +3 −10
src/backend/nodes/tidbitmap.c modified +2 −5
src/backend/parser/parse_agg.c modified +2 −1
src/backend/postmaster/autovacuum.c modified +3 −4
src/backend/replication/logical/reorderbuffer.c modified +2 −5
src/backend/replication/syncrep.c modified +2 −6
src/backend/utils/adt/oid.c modified +2 −5
src/backend/utils/adt/tsgistidx.c modified +3 −7
src/backend/utils/adt/tsquery_gist.c modified +3 −4
src/backend/utils/adt/tsvector.c modified +2 −3
src/backend/utils/adt/tsvector_op.c modified +2 −3
src/backend/utils/adt/xid.c modified +2 −5
src/backend/utils/cache/relcache.c modified +2 −1
src/backend/utils/cache/syscache.c modified +2 −3
src/backend/utils/cache/typcache.c modified +2 −6
src/backend/utils/resowner/resowner.c modified +2 −8
src/bin/pg_dump/pg_dump_sort.c modified +2 −5
src/bin/pg_upgrade/function.c modified +6 −6
src/bin/pg_walsummary/pg_walsummary.c modified +2 −6
src/bin/psql/crosstabview.c modified +2 −1
src/include/access/gin_private.h modified +2 −6

Discussion