Horton

Don't fall off the end of perl functions

Andrew Dunstan <andrew@dunslane.net>

View on postgr.es
Commit: 3a7cc727c7c502353dbb730a0db793abec4de44b
Author: Andrew Dunstan <andrew@dunslane.net>
Date: 2018-05-27T13:08:42Z
Releases: 11.0 
Don't fall off the end of perl functions

This complies with the perlcritic policy
Subroutines::RequireFinalReturn, which is a severity 4 policy. Since we
only currently check at severity level 5, the policy is raised to that
level until we move to level 4 or lower, so that any new infringements
will be caught.

A small cosmetic piece of tidying of the pgperlcritic script is
included.

Mike Blackwell

Discussion: https://postgr.es/m/CAESHdJpfFm_9wQnQ3koY3c91FoRQsO-fh02za9R3OEMndOn84A@mail.gmail.com

Files

PathChange+/−
contrib/bloom/t/001_wal.pl modified +1 −0
contrib/intarray/bench/create_test.pl modified +1 −0
src/backend/catalog/Catalog.pm modified +1 −0
src/backend/catalog/genbki.pl modified +4 −0
src/backend/parser/check_keywords.pl modified +1 −0
src/backend/utils/mb/Unicode/convutils.pm modified +5 −0
src/backend/utils/sort/gen_qsort_tuple.pl modified +4 −0
src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl modified +2 −0
src/bin/pgbench/t/001_pgbench_with_server.pl modified +3 −0
src/bin/pgbench/t/002_pgbench_no_server.pl modified +2 −0
src/bin/pg_rewind/RewindTest.pm modified +13 −0
src/bin/pg_rewind/t/001_basic.pl modified +1 −0
src/bin/pg_rewind/t/002_databases.pl modified +1 −0
src/bin/pg_rewind/t/003_extrafiles.pl modified +1 −0
src/bin/pg_rewind/t/004_pg_xlog_symlink.pl modified +1 −0
src/include/catalog/reformat_dat_file.pl modified +1 −0
src/interfaces/ecpg/preproc/parse.pl modified +6 −0
src/pl/plperl/plc_perlboot.pl modified +1 −0
src/pl/plperl/text2macro.pl modified +1 −0
src/test/authentication/t/001_password.pl modified +2 −0
src/test/authentication/t/002_saslprep.pl modified +2 −0
src/test/kerberos/t/001_auth.pl modified +1 −0
src/test/ldap/t/001_auth.pl modified +1 −0
src/test/perl/PostgresNode.pm modified +29 −1
src/test/perl/SimpleTee.pm modified +1 −1
src/test/perl/TestLib.pm modified +14 −0
src/test/recovery/t/001_stream_rep.pl modified +3 −0
src/test/recovery/t/003_recovery_targets.pl modified +2 −0
src/test/recovery/t/007_sync_rep.pl modified +1 −0
src/test/recovery/t/009_twophase.pl modified +1 −0
src/test/ssl/ServerSetup.pm modified +9 −0
src/tools/copyright.pl modified +1 −0
src/tools/git_changelog modified +3 −0
src/tools/msvc/builddoc.pl modified +1 −1
src/tools/msvc/gendef.pl modified +3 −0
src/tools/msvc/Install.pm modified +13 −0
src/tools/msvc/Mkvcbuild.pm modified +5 −0
src/tools/msvc/MSBuildProject.pm modified +11 −0
src/tools/msvc/Project.pm modified +15 −0
src/tools/msvc/Solution.pm modified +5 −0
src/tools/msvc/VCBuildProject.pm modified +5 −0
src/tools/msvc/vcregress.pl modified +14 −0
src/tools/pginclude/pgcheckdefines modified +2 −0
src/tools/pgindent/pgindent modified +7 −0
src/tools/pgperlcritic/perlcriticrc modified +5 −0
src/tools/pgperlcritic/pgperlcritic modified +1 −1
src/tools/version_stamp.pl modified +1 −0

Discussion