Horton

pg_createsubscriber: Fix matching check in TAP test

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 39e22b3adaa7738da4d7ff536a2ab5e303e7c890
Author: Michael Paquier <michael@paquier.xyz>
Date: 2025-10-17T04:01:17Z
Releases: 18.1 
pg_createsubscriber: Fix matching check in TAP test

040_pg_createsubscriber has been calling safe_psql(), that returns the
result of a SQL query, with ok() without checking the result generated
(in this case 't', for a number of publications).

The outcome of the tests is currently not impacted by this change.
However, it could be possible that the test fails to detect future
issues if the query results become different.

The test is rewritten so as the number of publications is checked.  This
is not the fix suggested originally by the author, but this is more
reliable in the long run.

Oversight in e5aeed4b8020.

Author: Sadhuprasad Patro <b.sadhu@gmail.com>
Discussion: https://postgr.es/m/CAFF0-CHhwNx_Cv2uy7tKjODUbeOgPrJpW4Rpf1jqB16_1bU2sg@mail.gmail.com
Backpatch-through: 18

Files

PathChange+/−
src/bin/pg_basebackup/t/040_pg_createsubscriber.pl modified +2 −2

Discussion