> Uh, isn't the correct fix

Bruce Momjian <bruce@momjian.us>

Commit: 394925b60dad238c3eb5f9b21b282b3d116bec62
Author: Bruce Momjian <bruce@momjian.us>
Date: 2001-10-15T18:16:31Z
Releases: 7.2.1
 > Uh, isn't the correct fix
 > ! $$ = cat_str(8, make_str("grant"), $2, make_str("on"), $4, $5,
 > make_str("to"), $7, $8);
 > ISTM your patch loses the opt_with_grant clause.  (Of course the
 > backend doesn't currently accept that clause anyway, but that's no
 > reason for ecpg to drop it.)

My patch doesn't loose the option, it's never been passed on anyway:

 opt_with_grant:  WITH GRANT OPTION
                                {
                                        mmerror(ET_ERROR, "WITH GRANT OPTION is not supported.  Only relation owners can
 set privileges");
                                 }
                | /*EMPTY*/
                ;

The existing code in ecpg/preproc/preproc.y to handle the WITH option
simply throws an error and aborts the processing... The patch below
prevents the segfault and also passes on the WITH option to the
backend, probably a better fix.

Lee Kindness

Files

PathChange+/−
src/interfaces/ecpg/preproc/preproc.y modified +3 −6