Improve handling of password reuse in src/bin/scripts programs.
Tom Lane <tgl@sss.pgh.pa.us>
Improve handling of password reuse in src/bin/scripts programs. This reverts most of commit 83dec5a71 in favor of having connectDatabase() store the possibly-reusable password in a static variable, similar to the coding we've had for a long time in pg_dump's version of that function. To avoid possible problems with unwanted password reuse, make callers specify whether it's reasonable to attempt to re-use the password. This is a wash for cases where re-use isn't needed, but it is far simpler for callers that do want that. Functionally there should be no difference. Even though we're past RC1, it seems like a good idea to back-patch this into 9.5, like the prior commit. Otherwise, if there are any third-party users of connectDatabase(), they'll have to deal with an API change in 9.5 and then another one in 9.6. Michael Paquier
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/scripts/clusterdb.c | modified | +2 −2 |
| src/bin/scripts/common.c | modified | +25 −23 |
| src/bin/scripts/common.h | modified | +2 −2 |
| src/bin/scripts/createlang.c | modified | +4 −4 |
| src/bin/scripts/createuser.c | modified | +2 −2 |
| src/bin/scripts/droplang.c | modified | +4 −4 |
| src/bin/scripts/dropuser.c | modified | +2 −2 |
| src/bin/scripts/reindexdb.c | modified | +4 −4 |
| src/bin/scripts/vacuumdb.c | modified | +11 −55 |