Support PlaceHolderVars in MERGE actions.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 3908d6ae115801cc61486b286ab71d91c2cdbb99
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-03-15T15:59:18Z
Releases: 15.3
Support PlaceHolderVars in MERGE actions.

preprocess_targetlist thought PHVs couldn't appear here.
It was mistaken, as per report from Önder Kalacı.

Surveying other pull_var_clause calls, I noted no similar errors,
but I did notice that qual_is_pushdown_safe's assertion about
!contain_window_function was pointless, because the following
pull_var_clause call would complain about them anyway.  In HEAD
only, remove the redundant Assert and improve the commentary.

Discussion: https://postgr.es/m/CACawEhUuum-gC_2S3sXLTcsk7bUSPSHOD+g1ZpfKaDK-KKPPWA@mail.gmail.com

Files

Discussion