ALTER TABLE DROP COLUMN works. Patch by Christopher Kings-Lynne,

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 38bb77a5d15aa022248488bc8c0147139ce120a9
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2002-08-02T18:15:10Z
Releases: 7.3.1
ALTER TABLE DROP COLUMN works.  Patch by Christopher Kings-Lynne,
code review by Tom Lane.  Remaining issues: functions that take or
return tuple types are likely to break if one drops (or adds!)
a column in the table defining the type.  Need to think about what
to do here.

Along the way: some code review for recent COPY changes; mark system
columns attnotnull = true where appropriate, per discussion a month ago.

Files

PathChange+/−
contrib/dblink/dblink.c modified +57 −33
doc/src/sgml/catalogs.sgml modified +12 −1
doc/src/sgml/ref/alter_table.sgml modified +59 −33
doc/src/sgml/ref/copy.sgml modified +12 −17
doc/src/sgml/release.sgml modified +3 −1
src/backend/access/common/tupdesc.c modified +6 −3
src/backend/bootstrap/bootstrap.c modified +28 −23
src/backend/catalog/dependency.c modified +3 −2
src/backend/catalog/heap.c modified +80 −8
src/backend/catalog/pg_proc.c modified +32 −19
src/backend/commands/analyze.c modified +11 −16
src/backend/commands/comment.c modified +3 −3
src/backend/commands/copy.c modified +294 −287
src/backend/commands/indexcmds.c modified +3 −9
src/backend/commands/tablecmds.c modified +148 −54
src/backend/optimizer/prep/preptlist.c modified +20 −7
src/backend/optimizer/prep/prepunion.c modified +11 −4
src/backend/parser/analyze.c modified +12 −13
src/backend/parser/parse_func.c modified +4 −1
src/backend/parser/parse_relation.c modified +139 −12
src/backend/parser/parse_target.c modified +7 −3
src/backend/parser/parse_type.c modified +3 −3
src/backend/rewrite/rewriteDefine.c modified +11 −1
src/backend/rewrite/rewriteHandler.c modified +5 −1
src/backend/utils/adt/not_in.c modified +3 −26
src/backend/utils/cache/lsyscache.c modified +5 −32
src/backend/utils/cache/syscache.c modified +66 −1
src/bin/pg_dump/pg_dump.c modified +34 −19
src/bin/pg_dump/pg_dump.h modified +2 −1
src/bin/psql/describe.c modified +2 −2
src/bin/psql/tab-complete.c modified +2 −2
src/include/catalog/catversion.h modified +2 −2
src/include/catalog/heap.h modified +2 −1
src/include/catalog/pg_attribute.h modified +231 −225
src/include/catalog/pg_class.h modified +2 −2
src/include/executor/executor.h modified +1 −2
src/include/parser/parse_relation.h modified +2 −2
src/include/utils/lsyscache.h modified +2 −3
src/include/utils/syscache.h modified +5 −1
src/pl/plpgsql/src/pl_comp.c modified +2 −5
src/test/regress/expected/alter_table.out modified +291 −3
src/test/regress/expected/copy2.out modified +38 −6
src/test/regress/sql/alter_table.sql modified +160 −0
src/test/regress/sql/copy2.sql modified +6 −0