Some *very* major changes by darrenk@insightdist.com (Darren King)
Marc G. Fournier <scrappy@hub.org>
Some *very* major changes by darrenk@insightdist.com (Darren King) ========================================== What follows is a set of diffs that cleans up the usage of BLCKSZ. As a side effect, the person compiling the code can change the value of BLCKSZ _at_their_own_risk_. By that, I mean that I've tried it here at 4096 and 16384 with no ill-effects. A value of 4096 _shouldn't_ affect much as far as the kernel/file system goes, but making it bigger than 8192 can have severe consequences if you don't know what you're doing. 16394 worked for me, _BUT_ when I went to 32768 and did an initdb, the SCSI driver broke and the partition that I was running under went to hell in a hand basket. Had to reboot and do a good bit of fsck'ing to fix things up. The patch can be safely applied though. Just leave BLCKSZ = 8192 and everything is as before. It basically only cleans up all of the references to BLCKSZ in the code. If this patch is applied, a comment in the config.h file though above the BLCKSZ define with warning about monkeying around with it would be a good idea. Darren darrenk@insightdist.com (Also cleans up some of the #includes in files referencing BLCKSZ.) ==========================================
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/nbtree/nbtsort.c | modified | +10 −11 |
| src/backend/catalog/index.c | modified | +28 −29 |
| src/backend/executor/nodeHash.c | modified | +3 −7 |
| src/backend/executor/nodeHashjoin.c | modified | +3 −10 |
| src/backend/optimizer/path/costsize.c | modified | +3 −6 |
| src/backend/optimizer/path/xfunc.c | modified | +14 −17 |
| src/backend/rewrite/rewriteDefine.c | modified | +8 −9 |
| src/backend/storage/buffer/localbuf.c | modified | +1 −2 |
| src/backend/storage/smgr/md.c | modified | +18 −5 |
| src/backend/tcop/postgres.c | modified | +25 −31 |
| src/backend/utils/adt/chunk.c | modified | +6 −11 |
| src/backend/utils/sort/psort.c | modified | +9 −14 |
| src/include/storage/bufmgr.h | modified | +7 −3 |
| src/include/storage/bufpage.h | modified | +11 −2 |
| src/include/storage/itemid.h | modified | +4 −4 |