Address points made in post-commit review of replication origins.
Andres Freund <andres@anarazel.de>
Address points made in post-commit review of replication origins. Amit reviewed the replication origins patch and made some good points. Address them. This fixes typos in error messages, docs and comments and adds a missing error check (although in a should-never-happen scenario). Discussion: CAA4eK1JqUBVeWWKwUmBPryFaje4190ug0y-OAUHWQ6tD83V4xg@mail.gmail.com Backpatch: 9.5, where replication origins were introduced.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/catalogs.sgml | modified | +5 −4 |
| doc/src/sgml/func.sgml | modified | +1 −1 |
| doc/src/sgml/replication-origins.sgml | modified | +1 −1 |
| src/backend/access/transam/xloginsert.c | modified | +1 −1 |
| src/backend/replication/logical/origin.c | modified | +11 −8 |